Editing Multiple Models in One Form (Page 1 of 4)

I used this method to successfully edit two models in my app--but how would one go about adding a third model?--AND, what if that third model was called with a collection_select method?

Here's a snippet from my _form.rhtml partial:

<% for @conversation in @memory.conversations %>
<p><label for="conversation_message">Message:</label><br />
    <%= collection_select('author', 'id', @authors, 'id', 'name') %>
    <% fields_for "conversation_#{@conversation.id}", @conversation do |f| %>
    <%= f.text_field :message %></p>
    <% end %>
<% end %>

In my memories_controller, i've got this:

  def edit
    @memory = Memory.find(params[:id])
    @authors = Author.find_all 
  end

Last edited by darrenemo (2006-11-06 05:04:57)

Thanks for the reply--ill try it out later

Good catch taoweb! However, won't your suggestion still have the same problem? I'm assuming any? will stop on the first true that is returned. I haven't tested it though.

To solve this I suppose it can be split into two lines:

@project.tasks.each(&:valid?) # run the validations
if @project.valid? && @project.tasks.all? { |t| t.errors.empty? }

Rails actually has this functionality built in already. Note the [] in the form_for call:

<%
conversation = Conversation.find(21) # could be assigned e.g. in a loop
form_for "conversation[]", conversation do |f| %>
<%= f.text_field :message %>
<% end %>

leads to

<input name="conversation[21][message]" ...>

This works the same with fields_for as well

Ive started my project over and for the life of me, can't get the update method to work! I've looked over the code at least 20 times, comparing it with the tutorial--no dice. whats up?

#memories_controller.rb
def edit
    @memory = Memory.find(params[:id])
    @authors = Author.find(:all)
  end
   def update
     @memory = Memory.find(params[:id])
     @memory.attributes = params[:memory]
     @memory.conversations.each { |t| t.attributes = params[:conversation][t.id.to_s] }
     if @memory.valid? && @memory.conversations.all?(&:valid?)
       @memory.save!
       @memory.conversations.each(&:save!)
       redirect_to :action => 'show', :id => @memory
     else
       render :action => 'edit'
     end
   end

#edit.rhtml
<h1>Editing memory</h1>
<%= error_messages_for :memory %>
<%= start_form_tag :action => 'update', :id => params[:id] %>
<p>
    Memory Title:
    <%= text_field :memory, :name %>
</p>
<p>
    <%= date_select :memory, :memory_date %>
</p>
 <% for @conversation in @memory.conversations %>
 <p><label for="conversation_message">Message:</label><br />
   <% fields_for "conversation_#{@conversation.id}", @conversation do |f| %>
     <%= f.collection_select(:author_id, @authors, :id, :name) %>
     <%= f.text_field :message %></p>
   <% end %>
 <% end %> 


<p><%= submit_tag 'Update' %></p>
<%= end_form_tag %>

Last edited by darrenemo (2006-11-12 00:19:21)

So everything is going good--i'm creating and editing memories, but my new.rhtml will also save conversations even if the message is blank.  (each conversation has an author (conversation.author_id and a conversation.message)

how can I edit the

#memories.controller.rb
@memory.conversations.build(conversation) unless conversation.values.all?(&:blank?)

would it be something like:

@memory.conversations.build(conversation) unless @memory.conversations(params[:message]).blank?

Heres the full method:

 def create
      @authors = Author.find(:all)
      @memory = Memory.new(params[:memory])
      params[:conversations].each_value do |conversation|
         @memory.conversations.build(conversation) unless conversation.values.all?(&:blank?)
      end
      if @memory.save
        redirect_to :action => 'index'
      else
        render :action => 'new'
      end
    end

Last edited by darrenemo (2006-11-13 17:37:03)

Sorry I've been away. I'm still planning on writing another tutorial for creating and editing models in the same form, but I haven't gotten around to it yet. Hopefully I'll have something up in a couple days if things go well.

Try unless conversation[:message].blank?

Take a look at the development log and see the parameters that are being passed to the action, this is what you should supply for your test. Something like this:

post 'update', :project => { :name => 'foo' }, :task => { '1' => { :name => 'bar' }, '2' => { :name => 'foobar' } }