Beginners: File uploads and rendering images to the database (Page 2 of 3)

Where abouts would i find that file?

Hi Mr.Dizzy

I did everything you proposed except the way I created the table. Instead of migrations I used plain mysql as given below.

create table photos (
id int not null auto_increment,
description varchar(100) not null,
content_type varchar(100) not null,
filename varchar(100) not null,
binary_data binary,
primary key (id)
);

inspite of all this, I get the gibberish in list under the binary_data filed and text 'Image' in show. The image is not getting displayed

What could I be missing?

Cheers
Cass

Hi ! Newbie here..trying to acheive what Max wanted....anyone can help ? to display the image on the /list.rhtml as well...

thks alot !

Those people trying to get this to work in a list:

I managed to get it to work by removing the '@' from the Photo.id, so:

<%= image_tag("/photo_admin/code_image/#{@photo.id}", :alt => "Image") %>

changed to:

<%= image_tag("/photo_admin/code_image/#{photo.id}", :alt => "Image") %>

Last edited by mike.rowlands (2007-08-17 05:40:06)

This is a brilliant tutorial that's helped me learn quite a bit of Ruby, but like others, I'm having trouble getting the images to display on the list.rhtml page.

This didn't work for me.

Here's my list.rhtml file. I'm certain it's something simple that's stumping me:

<h1>Listing photos</h1>
<table>
  <tr>
  <% for column in Photo.content_columns %>
    <th><%= column.human_name %></th>
    
  <% end %>
  </tr>
  
<% for photo in @photos %>
  <tr>
  <% for column in Photo.content_columns %>
    <% if column.name == "binary_data" %>
      <%= image_tag("/photo_admin/code_image/#{@Photo.id}", :alt => "Image") %>
    <% else %>  
      <%=h @Photo.send(column.name) %>
    <% end %>
  <% end %>
  <td><%= link_to 'Show', :action => 'show', :id => photo %></td>
  <td><%= link_to 'Edit', :action => 'edit', :id => photo %></td>
  <td><%= link_to 'Destroy', { :action => 'destroy', :id => photo }, :confirm => 'Are you sure?', :method => :post %></td>
  </tr>
<% end %>
</table>
<%= link_to 'Previous page', { :page => @photo_pages.current.previous } if @photo_pages.current.previous %>
<%= link_to 'Next page', { :page => @photo_pages.current.next } if @photo_pages.current.next %> 
<br />
<%= link_to 'New photo', :action => 'new' %>

Last edited by Cosmonaut (2007-08-29 03:26:35)

Good stuff guys, thanks for the tutorial.  I successfully integrated the upload action into a user model for a project I'm working on, and am happy with the results.  Now on to the rendering, but I'm not too worried about that :-)

I do have a question, however.  Where does Ruby get information about the file, its filetype, and its original filename - the browser?  I see this being a problem if Ruby relies on the browser for this information, as an attacker could tweak the information to SAY that something's a picture (or a PDF, Word document, etc.)

Also, if it's the browser that gives it that information, how would you "police" the content type?  For example, I don't want to allow any content that isn't PDF, RTF or Word.  I'd have to examine the content-type in Ruby (if obj.content_type == "PDF").  But, if the browser supplies the string defining the content type, then we could have a different string for each kind of browser that's sending the information.  Testing on Safari on OS X shows me that my PDFs are being uploaded as type, "application/pdf".  That seems like a valid MIME type, but as we know, MSIE doesn't always follow the rules.

What are your suggestions/thoughts on this?  Thanks again for a great tutorial

Was wondering how to modify this to allow for uploading of alternate file types - ie pdfs.

I made the change I thought necessary but after I upload the pdf, I go to:
/photo_admin/code_image/5

and I get "the file is damaged and could not be repaired".....

Is there a problem with the way I've uploaded or pulled the file since it is a different file type than specified here?

Last edited by nikikelly74 (2007-10-23 21:21:29)

I know this is late, but thanks to everyone who helped. My uploads are working like a dream.

This is a wonderful tutorial... and yes, I'm a newbie working my way through both the Ruby language and the Rails intricacies.

Anyways, I've worked through this content and have everything working, except...

1. I cannot get a JPG file to display.  I get the standard browser "alt" empty box.  The file data has made it into the database (checked that), and I've stepped through the code using NetBeans and found that the elements in the image/photo table are retrieved properly (filename, content type, etc.).  Below is the code in my pictures_controller.rb file for rendering:

  def code_picture
    @picture_data = Picture.find(params[:id]) 
    @picture = @picture_data.filedata 
    send_data(@picture, :type => @picture_data.content_type, :filename =>  @picture_data.filename, :disposition => 'inline')
  end

As far as I can tell, the correct data is in @picture_data as well as @picture.

Can anyone provide a direction to explore for this?

2. I still have to figure out mySQL to figure out how to make my blobs bigger.  Any help there would be helpful as well.

Thanks in advance and for a wonderful tutorial.
B.